Merged
Conversation
Contributor
Author
|
I think there might be a couple of issues. There is no way to tell whether a I'll go through it this week and try to fix the remaining parts of the |
Member
|
The climb comments are welcomed since it clarified the functions. I would have preferred it as a separate PR, but I think I can still merge it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Try running this code:
What you'll see is the following:
[ { "type": "ExprStmt", "expr": { "type": "=", "expr": { "type": "IndexExpr", "args": [ { "type": "LiteralExpr", "value": "1" } ] }, "value": { "type": "IdentifierExpr", "value": "v" } } } ]As can be seen our identifier
array(or whatever might be on the left hand side), is never included in the expression node.This PR adds an
exprparameter to theIndexExprnode. Now our tree looks like this:[ { "type": "ExprStmt", "expr": { "type": "=", "expr": { "type": "IndexExpr", "expr": { "type": "IdentifierExpr", "value": "array" }, "args": [ { "type": "LiteralExpr", "value": "1" } ] }, "value": { "type": "IdentifierExpr", "value": "v" } } } ]Oh, and there's also a small documentation addition for
clib.named_struct()which I accidentally committed. 😅