Fix Kitty Unicode placeholder rendering for scrollable images #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes multiple issues with Kitty graphics protocol support,
particularly for Unicode placeholder mode which enables images to scroll
with terminal content.
Key changes:
1. Two-step rendering for Unicode placeholders
- Transmit image data as PNG without display (f=100,t=d)
- Create virtual placement with U=1 and explicit cols/rows (a=p,U=1)
- Generate placeholder characters with image ID in foreground color
- Skip pre-resizing when using Unicode placeholders (terminal scales)
2. Fix image ID encoding
- Add globalKittyImageNum counter for 24-bit compatible image numbers
- Use small sequential numbers (1-0xFFFFFF) that fit in RGB encoding
3. Fix ClearAll functions
- Use d=A (delete ALL) instead of just a=d
- Add missing escape sequence terminator (\x1b\\)
4. Skip terminal queries when protocol detected from environment
- If Kitty/iTerm2 detected via KITTY_WINDOW_ID, TERM, etc., skip all
terminal queries to avoid leaving garbage in stdin buffer
- Fixes first-keypress issues with TUI frameworks like bubbletea
5. Fix TOCTOU race condition in ResizeCache
- Use atomic file operations to prevent race conditions
Author
|
@blacktop may I ask if there is somebody that can take a look at this? I have tested it on my end and can see that images scroll, but I would love to have a more complete review in case I need to make some changes. |
Owner
|
Apologies for being slow to respond; looking this it looks good, just trying to find the time to give it a thorough review. |
Author
Oh, no worries. I understand the issues with finding time. I was just making sure the project wasn't stale. I know people lose focus (like me). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes multiple issues with Kitty graphics protocol support, particularly for Unicode placeholder mode which enables images to scroll with terminal content.
Key changes
Two-step rendering for Unicode placeholders
f=100,t=d)U=1and explicit cols/rows (a=p,U=1)Fix image ID encoding
globalKittyImageNumcounter for 24-bit compatible image numbersFix ClearAll functions
d=A(delete ALL) instead of justa=d\x1b\\)Skip terminal queries when protocol detected from environment
KITTY_WINDOW_ID,TERM, etc., skip all terminal queries to avoid leaving garbage in stdin bufferFix TOCTOU race condition in ResizeCache
Test plan