added half-stars and rounding to closest half#3
Open
retosteffen wants to merge 3 commits intoblackknight467:masterfrom
Open
added half-stars and rounding to closest half#3retosteffen wants to merge 3 commits intoblackknight467:masterfrom
retosteffen wants to merge 3 commits intoblackknight467:masterfrom
Conversation
Open
Owner
|
@pije76 sorry for the delay. I'll review this pull request tomorrow and see if i can fix some of the conflicts with the current branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I need to have half-starts for some average of ratings and they exist in font awesome.
I modified the bundle to round to the closest half and show half-stars.
Comments welcome!