fix(readme): update path to binary#7
Open
StoneSet wants to merge 1 commit intoblackccpie:masterfrom
StoneSet:patch-1
Open
fix(readme): update path to binary#7StoneSet wants to merge 1 commit intoblackccpie:masterfrom StoneSet:patch-1
StoneSet wants to merge 1 commit intoblackccpie:masterfrom
StoneSet:patch-1
Conversation
blackccpie
reviewed
Oct 14, 2018
| ```shell | ||
| $ ./deezzy | ||
| ``` | ||
| You can found the binary in /home/pi/deezzy/bin/, and run `./deezzy` in the correct folder to start streaming. |
Owner
There was a problem hiding this comment.
@StoneSet : je comprends qu'il manque une info dans la doc, mais ça ne me semble pas le meilleur moyen de la formuler, sachant que tout le monde n'aura pas forcément cloné le repo sous /home/pi. Je pense qu'il vaudrait mieux rajouter une ligne dans l'étape 4 (le build), avec une commande ls bin et son résultat qui montre où sont les binaires. Qu'en penses-tu?
Author
There was a problem hiding this comment.
Effectivement c'est une bonne idée et surement plus compréhensible. Je n'ai toujours pas eu le temps de me repencher sur le problème, j’essaierais cette semaine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.