ENH: CMakeLists.txt headers and installation fixed. STYLE: Indents and line length#5
Open
aylward wants to merge 10 commits intobjoern-andres:masterfrom
Open
ENH: CMakeLists.txt headers and installation fixed. STYLE: Indents and line length#5aylward wants to merge 10 commits intobjoern-andres:masterfrom
aylward wants to merge 10 commits intobjoern-andres:masterfrom
Conversation
ENH: Update style and complete definitions in top-level CMakeLists.txt
BUG: Pull request from dariovillar dfe0630 fixes compilation bug
BUG: Must cast return var to return type.
BUG: use of std::multiples requires inclusion of stl functional
BUG: Install into the same directory structure as used in source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Line 2: Project name matches repository name.
Line 4: For header inclusion, limit to .hxx files to avoid modern cmake warning about attempting to add directories to a file list.
Lines 61 and 63: Specify output directories for Libs and Executables to simplify use of build tree in other projects.
Line 73: Specify an install command for header files to enable installation / out-of-build use.
All other lines - changed indent to 2 spaces and limited line length to 80 char to support consistent cross-editor appearance.