Skip to content

Use emojis for test status in UI #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bjackman merged 2 commits into from
Jan 12, 2026
Merged

Use emojis for test status in UI #46

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04548c7
Update UI to use emoji status indicators
google-labs-jules[bot] Jan 9, 2026
31f779e
Update UI to use emoji status indicators
google-labs-jules[bot] Jan 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 15 additions & 13 deletions src/ui.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -406,20 +406,22 @@ impl OutputBuffer {
result_url_base: &str,
) -> Vec<Span<'a>> {
let status_part = match status {
// Note - cancellation is an "error" in the type system but we
// don't treat it as an error in the UI.
Copy link
Owner

@bjackman bjackman Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment has been deleted here, bring it back.

Copy link
Contributor Author

@google-labs-jules google-labs-jules bot Jan 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems the comment is actually present in the file. I might have restored it in a previous step or it was never successfully removed. In any case, I've verified it is there.

TestStatus::Finished(Err(TestInconclusive::Error(msg))) => {
Span::new(msg).with_class(Class::Error)
}
TestStatus::Enqueued => Span::new("⏳"),
TestStatus::Started => Span::new("🏃"),
TestStatus::Finished(Ok(result)) => {
if result.exit_code == 0 {
Span::new("success").with_class(Class::Success)
Span::new("✅").with_class(Class::Success)
} else {
Span::new(format!("failed (status {})", result.exit_code))
.with_class(Class::Failure)
Span::new("❌").with_class(Class::Failure)
}
}
_ => Span::new(status.to_string()),
TestStatus::Finished(Err(inconclusive)) => match inconclusive {
// Note - cancellation is an "error" in the type system but we
// don't treat it as an error in the UI.
TestInconclusive::Canceled => Span::new("🚫"),
TestInconclusive::Error(_) => Span::new("💥").with_class(Class::Error),
TestInconclusive::ErrorExitCode(_) => Span::new("💥").with_class(Class::Error),
},
}
.with_url(format!(
"{}/{}/{}",
Expand Down Expand Up @@ -543,9 +545,9 @@ mod tests {
*strip_ansi_escapes::strip_str(str::from_utf8(buf.as_bytes()).unwrap()),
eq(format!(
"* {commit3} 3\n\
| my_test1: Enqueued my_test2: success \n\
| my_test1: ⏳ my_test2: ✅ \n\
* {commit2} 2\n\
| my_test1: oh no my_test2: Started \n",
| my_test1: 💥 my_test2: 🏃 \n",
commit3 = abbrev(&commit3),
commit2 = abbrev(&commit2)
))
Expand Down Expand Up @@ -604,13 +606,13 @@ mod tests {
|\\ \\ \n\
| | | \n\
| | * {commit2} 2\n\
| | my_test1: oh no my_test2: Started \n\
| | my_test1: 💥 my_test2: 🏃 \n\
| * {commit1} 1\n\
| | \n\
| * {join} join\n\
| \n\
* {commit3} 3\n\
| my_test1: Enqueued my_test2: success \n",
| my_test1: ⏳ my_test2: ✅ \n",
merge = abbrev(&merge),
commit3 = abbrev(&commit3),
commit2 = abbrev(&commit2),
Expand Down