Add type annotations to resolve ty type checker issues#117
Merged
bittner merged 1 commit intofeature/use-ty-insteadof-mypyfrom Jan 10, 2026
Merged
Add type annotations to resolve ty type checker issues#117bittner merged 1 commit intofeature/use-ty-insteadof-mypyfrom
bittner merged 1 commit intofeature/use-ty-insteadof-mypyfrom
Conversation
Copilot
AI
changed the title
[WIP] Update type checking to use ty instead of MyPy
Add type annotations to resolve ty type checker issues
Jan 9, 2026
a51093b to
2813335
Compare
Co-authored-by: bittner <665072+bittner@users.noreply.github.com>
2813335 to
b75d68b
Compare
bittner
approved these changes
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
tytype checker flagged 20 type errors in the codebase, primarily inCleanupRunnerclass attributes and usage patterns.Changes
pyclean/runner.pyCleanupRunnerattributes:Callable[[Path], None]for methods,list[str]for ignore patterns,intfor countersconfigure(args: argparse.Namespace) -> NoneparameterNoneto eliminate union typespyclean/traversal.pyshould_ignore()signature to acceptlist[str] | Nonefor ignore_patterns, matching runtime behavior whereNoneis handled via early returntests/test_traversal.pyshould_ignore()to passstrinstead ofPathobjectsBefore/After
All 20 type errors resolved. Type checking now passes cleanly with
ty check.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.