Skip to content

Conversation

@LeoDiazL
Copy link
Contributor

Adding EFS volume handling to ECS
Fixing some dependencies of lb_targets in ECS
Cosmetic README fixes

Copy link

@PhillypHenning PhillypHenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aws_ecs_efs

The EFS configuration that was added, based on the variable name, seems to be for ECS usage only. I just want to confirm:

  1. Do we support EFS mounting to an EC2 ?
  • Is the implementation different between EC2 and ECS?

@LeoDiazL
Copy link
Contributor Author

  • EC2 - supports mounting and creating an EFS volume through the action itself.
  • ECS - supports mounting. Creation could be added, but it's out of the scope of this PR. Variables added allows for more granular management for ECS.

Implementation of both is completely different. ECS configures it at the task and container definition level, EC2 needs to create a file with the disk info that's going to be mounted later on by an Ansible task.

What could be added

  • Handle multiple volumes - instead of one, we could accept a comma-separated list of volumes and mount them.
  • Add the EFS volumes variables set and if set to create, use that EFS FS ID instead. (That's the real thing we need here)
    Why not
  • The main idea of having an EFS volume is to persist data. Creating one is easy and requires very little click-ops work.
  • Handling more disks requires a bit more complex development, not that hard though, but one could get away with having one EFS volume and mounting it differently.

@github-actions
Copy link

⚠️ Terraform formatting issues detected. Run terraform fmt -recursive operations/deployment/terraform/aws/ to fix.

@github-actions
Copy link

⚠️ Terraform formatting issues detected. Run terraform fmt -recursive operations/deployment/terraform/aws/ to fix.

@github-actions
Copy link

⚠️ Terraform formatting issues detected. Run terraform fmt -recursive operations/deployment/terraform/aws/ to fix.

@LeoDiazL LeoDiazL merged commit a6b570a into main Jan 27, 2026
2 checks passed
@LeoDiazL LeoDiazL deleted the add_efs_to_ecs branch January 27, 2026 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants