Skip to content

Refactor input field styles to remove borders and manage focus state … #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyrregjerstad merged 2 commits into from
Nov 18, 2025
Merged

Refactor input field styles to remove borders and manage focus state … #13

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb4450
Refactor input field styles to remove borders and manage focus state …
kyrregjerstad Nov 18, 2025
873910e
cleanup
kyrregjerstad Nov 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions packages/experience/src/Providers/AppBoundary/bitfocus-custom-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@
font-size: 1.125rem; /* text-lg */
font-weight: 400;
color: #d4d4d8; /* text-neutral-300 */
border: 1px solid #404040; /* subtle border */
border: none; /* Remove border - NotchedBorder component handles this */
border-radius: 4px; /* rounded-sm */
padding: 4px 16px;
width: 100%;
Expand All @@ -135,8 +135,11 @@
#app form div[class*='inputField'] input:focus,
#app form div[class*='inputField'] div[class$='countryCodeSelector']:focus {
outline: none;
border-color: #3b82f6; /* focus ring color */
box-shadow: 0 0 0 3px rgba(59, 130, 246, 0.1);
}

/* Hide the purple outline to prevent double border on focus */
#app form div[class*='inputField'] ~ div fieldset[class*='outline'] {
display: none !important;
}
Comment on lines +141 to 143
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The use of !important should be avoided whenever possible as it breaks the natural CSS cascade and can make future styling and debugging more difficult. In this case, the selector #app form div[class*='inputField'] ~ div fieldset[class*='outline'] is already highly specific due to the #app ID. This specificity is sufficient to override the component's default styles, so !important is not needed.

Suggested change
#app form div[class*='inputField'] ~ div fieldset[class*='outline'] {
display: none !important;
}
#app form div[class*='inputField'] ~ div fieldset[class*='outline'] {
display: none;
}


/* Placeholder styling */
Expand Down
Loading