Skip to content

Update padding in password field #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyrregjerstad merged 1 commit into from
Nov 18, 2025
Merged

Update padding in password field #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/experience/src/Providers/AppBoundary/bitfocus-custom-styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,7 @@
color: #d4d4d8; /* text-neutral-300 */
border: 1px solid #404040; /* subtle border */
border-radius: 4px; /* rounded-sm */
padding: 4px 8px; /* px-2 py-1 */
padding: 4px 16px;
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Nov 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While it's good that you removed the outdated comment, it seems there's a convention in this file to add comments that map CSS values to utility classes (e.g., from Tailwind CSS). To maintain consistency with other styles in this file that have similar comments, it would be better to update the comment instead of removing it. Based on the previous comment (/* px-2 py-1 */ for padding: 4px 8px;), the convention seems to be px-* then py-*. The new padding of 4px 16px would correspond to py-1 and px-4. Therefore, the comment should be updated to /* px-4 py-1 */.

Suggested change
padding: 4px 16px;
padding: 4px 16px; /* px-4 py-1 */

width: 100%;
box-shadow: 0 1px 2px 0 rgba(0, 0, 0, 0.05);
}
Expand Down
Loading