Skip to content

add buttons asset#10

Merged
kyrregjerstad merged 1 commit intologto-bitfocusfrom
fix/add-buttons-asset
Nov 10, 2025
Merged

add buttons asset#10
kyrregjerstad merged 1 commit intologto-bitfocusfrom
fix/add-buttons-asset

Conversation

@kyrregjerstad
Copy link
Copy Markdown

Fixes the issues where the buttons logo is not found in the built version

@kyrregjerstad kyrregjerstad merged commit 317f6c0 into logto-bitfocus Nov 10, 2025
4 of 12 checks passed
@github-actions
Copy link
Copy Markdown

COMPARE TO master

Total Size Diff ⚠️ 📈 +72.47 KB

Diff by File
Name Diff
assets/buttons.png ⚠️ 📈 +19.09 KB
packages/console/src/components/Topbar/index.tsx 📈 +888 Bytes
packages/console/src/containers/ConsoleContent/Sidebar/hook.tsx 📈 +190 Bytes
packages/core/package.json 📈 +24 Bytes
packages/core/src/index.ts 📈 +727 Bytes
packages/core/src/main.ts 📈 +608 Bytes
packages/core/src/middleware/koa-auth/index.ts 📈 +84 Bytes
packages/core/src/middleware/koa-auth/utils.ts 📈 +612 Bytes
packages/core/src/middleware/koa-cors.ts 📈 +312 Bytes
packages/core/src/middleware/koa-security-headers.ts 📈 +276 Bytes
packages/core/src/routes/experience/verification-routes/password-verification.ts 📈 +174 Bytes
packages/core/src/utils/buttons-app-starter/appStarter.ts 📈 +7.46 KB
packages/core/src/utils/buttons-app-starter/redis.ts 📈 +3.54 KB
packages/core/src/utils/password-decryption.ts 📈 +3.24 KB
packages/core/src/utils/watchdog.ts 📈 +3.9 KB
packages/experience/package.json 📈 +64 Bytes
packages/experience/src/Providers/AppBoundary/AppMeta.tsx 📈 +369 Bytes
packages/experience/src/Providers/AppBoundary/bitfocus-custom-styles.css 📈 +6 KB
packages/experience/src/assets/buttons.png ⚠️ 📈 +19.09 KB
packages/experience/src/constants/env.ts 📈 +101 Bytes
packages/experience/src/hooks/use-encryption.ts 📈 +5.44 KB
packages/experience/src/hooks/use-external-iframe-signin.ts 📈 +1.17 KB
packages/experience/src/hooks/use-password-sign-in.ts 📈 +145 Bytes
packages/experience/src/pages/SignIn/index.tsx 📈 +89 Bytes
packages/experience/src/utils/crypto.ts 📈 +662 Bytes
packages/experience/vite.config.ts 📈 +53 Bytes
packages/schemas/src/types/interactions.ts 📈 +361 Bytes
packages/shared/src/node/env/UrlSet.ts 📈 +166 Bytes
pnpm-lock.yaml 📈 +2.09 KB

@gemini-code-assist
Copy link
Copy Markdown

Summary of Changes

Hello @kyrregjerstad, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical issue where the 'buttons' logo was not correctly displayed in the built application due to incorrect asset path resolution. The solution involves refactoring how the logo's URL is handled within the CSS. Instead of a static path, a dynamic approach is now used where the asset is imported directly into a TypeScript component, and its resolved URL is then injected into the CSS via a placeholder replacement mechanism. This ensures the logo asset is properly bundled and accessible in all environments.

Highlights

  • Dynamic Asset Loading: The buttons.png asset is now dynamically loaded and injected into the CSS at runtime, resolving issues with the logo not being found in built versions of the application.
  • CSS Placeholder Introduction: A new placeholder, BUTTONS_LOGO_PLACEHOLDER, has been introduced in bitfocus-custom-styles.css to allow for the dynamic injection of the logo's URL.
  • Asset Import and Replacement Logic: The buttons.png asset is now explicitly imported in AppMeta.tsx, and its resolved URL is used to replace the BUTTONS_LOGO_PLACEHOLDER within the raw CSS content.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses the issue of the buttons logo not being found in the built version by introducing a dynamic asset loading mechanism. The approach of using a placeholder in the CSS and replacing it with the imported asset URL in AppMeta.tsx is a robust solution. The changes are clear, well-implemented, and directly resolve the problem described.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant