Define insecure-algorithms permission property#189
Conversation
📝 WalkthroughWalkthroughA new boolean property Changes
Poem
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
assets/manifest.schema.json (1)
119-123: Nice addition — looks good! 👍Thanks for contributing this! The new
insecure-algorithmspermission follows the existing pattern nicely — consistent kebab-case naming, boolean type, and clear description. Placing it alongside the other permission flags and within theadditionalProperties: falseboundary is exactly right.One tiny thought (totally optional): you might consider expanding the description slightly to hint at the security trade-off, e.g., mentioning that this enables the
--openssl-legacy-providerflag, so someone reading the schema alone understands the implication. But the current wording is perfectly fine too — just a suggestion!💡 Optional: slightly more descriptive text
"insecure-algorithms": { "type": "boolean", - "description": "Enable if the module requires legacy openssl algorithms" + "description": "Enable if the module requires legacy openssl algorithms. This will start the module with the --openssl-legacy-provider flag, which may reduce security" }
|
ah, I was a little wrong. current companion complains if a module has that property set (we have |
Define manifest permissions property to enable use of the
--openssl-legacy-providerflag when starting connection process #187Requires accompanying work in Companion to support
Summary by CodeRabbit