Fix impossible type assertion in Remove method#8
Merged
Conversation
Merged
Co-authored-by: warkanum <208308+warkanum@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Introduce server manager for enhanced HTTP/HTTPS handling
Fix impossible type assertion in Remove method
Dec 30, 2025
warkanum
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Removemethod attempted to type assertInstanceinterface to*gracefulServer, butgracefulServerdoesn't implementInstance(missingAddr()method). This causedgo vetand linter failures.Changes:
instance.(*gracefulServer)toinstance.(*serverInstance)si.gracefulServer.shutdownTimeoutto traverse the wrapper structsi.gracefulServerbefore accessingshutdownTimeoutThe
serverInstancestruct properly implements theInstanceinterface and wrapsgracefulServerinternally.💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.