Fix recover() not working in CatchPanic functions

[Copilot]

The CatchPanic and CatchPanicCallback functions call recover() directly in their body, but recover() only works when called from within a deferred function. This renders panic recovery non-functional.

Changes

• Modified function signatures: Both functions now return func() that must be invoked
• Extracted context early: Context extraction moved outside closure to avoid capturing args slice
• Updated call sites: Added trailing () to all usages in pkg/security/provider.go
• Updated documentation: Fixed examples in pkg/errortracking/README.md

Usage

// Before (non-functional)
defer logger.CatchPanic("MyFunction")

// After (functional)
defer logger.CatchPanic("MyFunction")()

// With callback
defer logger.CatchPanicCallback("MyFunction", func(err any) {
    // cleanup
})()

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

[warkanum]

Just make sure everywhere we use CatchPanicCallback and logger.CatchPanic we call the inner function

[Copilot]

Just make sure everywhere we use CatchPanicCallback and logger.CatchPanic we call the inner function

Confirmed - all usages are already calling the inner function with ():

• pkg/security/provider.go:299: defer logger.CatchPanic("ApplyColumnSecurity")()
• pkg/security/provider.go:440: defer logger.CatchPanic("GetRowSecurityTemplate")()

The README documentation also shows the correct usage pattern with () at the end.

[warkanum]

Looks good