[WIP] Fix prefix addition in where queries and xfiles options#12
Merged
[WIP] Fix prefix addition in where queries and xfiles options#12
Conversation
Co-authored-by: warkanum <208308+warkanum@users.noreply.github.com>
Member
|
@copilot If the model is not registered, isValidColumn must fail on all columns. Therefore not modify or add any prefixes. Calls to isValidColumn without a model must be logged and fixed. |
…rrectly Co-authored-by: warkanum <208308+warkanum@users.noreply.github.com>
Co-authored-by: warkanum <208308+warkanum@users.noreply.github.com>
warkanum
approved these changes
Dec 30, 2025
Copilot stopped work on behalf of
warkanum due to an error
December 30, 2025 13:38
warkanum
approved these changes
Dec 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix incorrect table prefix addition in WHERE clauses
Problem
The
AddTablePrefixToColumnsfunction incorrectly adds table prefixes to SQL literals (liketrue,false,null) when they appear in complex WHERE clauses wrapped in parentheses, resulting in invalid SQL like"mastertask.true".Example of the Bug
This causes SQL errors like:
Root Cause
When processing
"(true AND status = 'active')":stripOuterParenthesesremoves parentheses →"true AND status = 'active'"extractLeftSideOfComparisonfinds the=operator and extracts everything before it →"true AND status""true AND status"as a column name and adds a prefixSolution
Modified
addPrefixToSingleConditionto:stripOneOuterParentheseshelper)stripOneMatchingOuterParenhelper to reduce code duplicationAfter Fix
Validation Complete
TestAddTablePrefixToColumns_ComplexConditionswith 9 test casesSecurity Summary
No security vulnerabilities detected by CodeQL analysis.
Impact
ERROR: column mastertask.true does not existOriginal prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.