fix: 🐛 Conditional into ternary & further github actions refinement

.github/dependabot.yml

@@ -15,8 +15,7 @@ updates:
       interval: "daily"
 
   # Maintain dependencies for yarn
-  - package-ecosystem: "yarn"
+  - package-ecosystem: "npm"
     directory: "/"
     schedule:
       interval: "daily"
-

.github/workflows/pull-request.yml

@@ -15,6 +15,7 @@ on:
 jobs:
   lint:
     runs-on: ubuntu-latest
+    if: (github.actor != 'dependabot[bot]')
     steps:
       - uses: amannn/action-semantic-pull-request@v3.4.2
         env:

.github/workflows/semgrep.yml

@@ -20,6 +20,7 @@ jobs:
       - uses: returntocorp/semgrep-action@v1
         with:
           generateSarif: "1"
+          auditOn: push
           config: >- # more at semgrep.dev/explore
             p/security-audit
             p/typescript
@@ -29,25 +30,6 @@ jobs:
             p/react
             p/r2c-ci
             p/owasp-top-ten
-            p/r2c-best-practices
-
-        # == Optional settings in the `with:` block
-
-        # Instead of `config:`, use rules set in Semgrep App.
-        # Get your token from semgrep.dev/manage/settings.
-        #   publishToken: ${{ secrets.SEMGREP_APP_TOKEN }}
-
-        # Never fail the build due to findings on pushes.
-        # Instead, just collect findings for semgrep.dev/manage/findings
-        #   auditOn: push
-
-        # Upload findings to GitHub Advanced Security Dashboard [step 1/2]
-        # See also the next step.
-
-
-        # Change job timeout (default is 1800 seconds; set to 0 to disable)
-        # env:
-        #   SEMGREP_TIMEOUT: 300
 
       # Upload findings to GitHub Advanced Security Dashboard [step 2/2]
       - name: Upload SARIF file for GitHub Advanced Security Dashboard

App.tsx

@@ -74,7 +74,7 @@ class App extends React.PureComponent {
   render() {
     return (
       <>
-        {!__DEV__ && <WithCodePush />}
+        {!__DEV__ ? <WithCodePush /> : null}
         <I18nextProvider i18n={i18n}>
           <Provider store={store}>
             <AppStateManager

src/components/Chip.tsx

@@ -22,7 +22,7 @@ export class Chip extends React.PureComponent<Props> {
         <Text style={[styles.label, this.props.textStyle]} testID={this.props.testID}>
           {this.props.label}
         </Text>
-        {this.props.removable && <Image source={icons.blackCross} style={styles.icon} />}
+        {this.props.removable ? <Image source={icons.blackCross} style={styles.icon} /> : null}
       </View>
     );
   }

src/components/Dropdown.tsx

@@ -17,7 +17,7 @@ export const Dropdown = ({ title, label, testID, onSelectPress }: Props) => {
     <View style={styles.header}>
       <TouchableOpacity testID={testID} style={styles.chooseWalletButton} onPress={onSelectPress}>
         <Text style={styles.chooseWalletButtonText}>{title}</Text>
-        {onSelectPress && <Image source={icons.iconDropdown} style={styles.icon} />}
+        {onSelectPress ? <Image source={icons.iconDropdown} style={styles.icon} /> : null}
       </TouchableOpacity>
       <View style={styles.descriptionContainer}>{label}</View>
     </View>

src/components/InputItem.tsx

@@ -131,7 +131,7 @@ export class InputItem extends Component<Props, State> {
     return (
       <View style={styles.container}>
         <Animated.Text style={[styles.label, { top, fontSize }]}>{label}</Animated.Text>
-        {!!suffix && <Text style={styles.suffix}>{suffix}</Text>}
+        {!!suffix ? <Text style={styles.suffix}>{suffix}</Text> : null}
         <BaseTextInput
           ref={this.inputItemRef}
           autoCorrect={false}

src/components/PinInput.tsx

@@ -39,7 +39,7 @@ export class PinInput extends PureComponent<Props> {
         keyboardType="number-pad"
         renderCell={({ index, symbol, isFocused }) => (
           <View key={index.toString()} style={[styles.cell, isFocused && styles.cellFocused]}>
-            {!!symbol && <View style={styles.cellMask} />}
+            {!!symbol ? <View style={styles.cellMask} /> : null}
           </View>
         )}
       />

src/components/PinView.tsx

@@ -28,7 +28,7 @@ export class PinView extends Component<Props> {
                 },
               ]}
             >
-              {isFilled && <View style={styles.cellMask} />}
+              {isFilled ? <View style={styles.cellMask} /> : null}
             </View>
           );
         })}

src/components/TransactionItem.tsx

@@ -43,7 +43,7 @@ export const TransactionItem = ({ item, onPress, testID }: Props) => {
         <Image source={icons.wallet} style={styles.wallet} resizeMode="contain" />
         <EllipsisText style={styles.walletLabel}>{item.walletLabel}</EllipsisText>
       </View>
-      {!!item.note && <Text style={typography.caption}>{item.note}</Text>}
+      {!!item.note ? <Text style={typography.caption}>{item.note}</Text> : null}
       <Text style={styles.label}>
         {item.time ? dayjs(item.received).format('LT') : i18n.transactions.details.timePending}
       </Text>

src/components/WalletItem.tsx

@@ -31,7 +31,7 @@ export const WalletItem = (props: WalletItemProps) => {
     <TouchableOpacity testID={testID} style={styles.container} onPress={onWalletPress}>
       <View>
         <Avatar variant={variant} title={title} />
-        {selected && <Image style={styles.image} source={images.successBadge} />}
+        {selected ? <Image style={styles.image} source={images.successBadge} /> : null}
       </View>
       <View style={styles.textContainer}>
         <Text style={typography.headline5}>{i18n.formatBalance(Number(value), unit, true)}</Text>

src/navigators/Navigator.tsx

@@ -274,10 +274,10 @@ class Navigator extends React.Component<Props, State> {
           shouldRenderNotification={this.shouldRenderNotification()}
           userVersion={userVersion}
         />
-        {isAuthenticated && <Toasts />}
-        {isToast && <Toasts onClick={this.handleClickToast} />}
-        {this.shouldRenderConnectionIssues() && <ConnectionIssuesScreen />}
-        {this.shouldRenderUnlockScreen() && <UnlockScreen key={unlockKey} />}
+        {isAuthenticated ? <Toasts /> : null}
+        {isToast ? <Toasts onClick={this.handleClickToast} /> : null}
+        {this.shouldRenderConnectionIssues() ? <ConnectionIssuesScreen /> : null}
+        {this.shouldRenderUnlockScreen() ? <UnlockScreen key={unlockKey} /> : null}
       </>
     );
   };

src/screens/ExportWalletScreen.tsx

@@ -30,7 +30,7 @@ export const ExportWalletScreen = ({ route }: Props) => {
     <ScreenTemplate header={<Header title={i18n.wallets.exportWallet.header} isBackArrow />}>
       <Text style={styles.title}>{i18n.wallets.exportWallet.title}</Text>
       <View testID="export-wallet-qr-code" style={styles.qrCodeContainer}>
-        {secret && <QRCode quietZone={10} value={secret} size={140} ecl={'H'} />}
+        {secret ? <QRCode quietZone={10} value={secret} size={140} ecl={'H'} /> : null}
       </View>
       <Mnemonic testID="export-wallet-seed-phrase" mnemonic={secret} />
 

src/screens/MessageScreen.tsx

@@ -38,7 +38,7 @@ export const MessageScreen = (props: Props) => {
       <Text style={styles.title}>{title}</Text>
       <Image testID={testID} source={source} style={[styles.image, imageStyle]} resizeMode="contain" />
       <Text style={styles.description}>{description}</Text>
-      {buttonProps && <Button testID="message-close-button" {...buttonProps} />}
+      {buttonProps ? <Button testID="message-close-button" {...buttonProps} /> : null}
     </View>
   );
 };

src/screens/Notifications/ConfirmEmailScreen.tsx

@@ -225,7 +225,7 @@ class ConfirmEmailScreen extends Component<Props, State> {
               onTextChange={this.onChange}
               isError={!!notificationError}
             />
-            {!!notificationError && <Text style={styles.error}>{notificationError}</Text>}
+            {!!notificationError ? <Text style={styles.error}>{notificationError}</Text> : null}
           </View>
         </>
       </ScreenTemplate>

src/screens/SeedPhraseConfirmScreen/SeedPhraseConfirmView.tsx

@@ -29,7 +29,7 @@ export const SeedPhraseConfirmView: FC<Props> = ({
       <View style={[styles.mnemonicPhraseContainer, error ? { borderColor: palette.primary } : {}]}>
         <Tags words={orderedMnemonics} onTagsOrderChange={onSeedOrderChange} onRemove={onSeedRemovePress} removable />
       </View>
-      {error && <Text style={styles.errorText}>{i18n.wallets.confirmSeed.error}</Text>}
+      {error ? <Text style={styles.errorText}>{i18n.wallets.confirmSeed.error}</Text> : null}
       <View style={styles.mnemonicPhraseUnselectedContainer}>
         <Tags words={unorderedMnemonics} onTouch={onTouch} touchable />
       </View>

src/screens/SendCoinsConfirmScreen.tsx

@@ -177,7 +177,7 @@ class SendCoinsConfirmScreen extends Component<Props> {
 
     return (
       <View style={styles.balancesContainer}>
-        {isAlert && <Warning />}
+        {isAlert ? <Warning /> : null}
         <View style={styles.balanceWrapper}>
           <Text style={styles.balanceText}>
             {roundBtcToSatoshis(availableBalance)} {fromWallet.preferredBalanceUnit}

src/screens/SendCoinsScreen.tsx

@@ -558,7 +558,7 @@ class SendCoinsScreen extends Component<Props, State> {
           unit={wallet.preferredBalanceUnit}
         />
         <View style={styles.inputsContainer}>
-          {this.isAlert(wallet) && <Warning />}
+          {this.isAlert(wallet) ? <Warning /> : null}
           {this.renderAmountInput()}
 
           <View style={styles.fee}>