init: clean up load chainstate function#240
Open
Ataraxia009 wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
init: clean up load chainstate function#240Ataraxia009 wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Ataraxia009 wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
bigshiny90
approved these changes
Dec 4, 2025
bigshiny90
left a comment
bigshiny90
left a comment
There was a problem hiding this comment.
Very straight-forward and logical.
ACK 923c3ab
mhrussell1
approved these changes
Dec 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleaning up
LoadChainTipfunction, had some unnecessary/redundant lines of code, more specifically:GetBestBlock()tip = m_chain.Tip();LogPrintftoLogInfo