Pass critical CFLAGS/CXXFLAGS to more build steps#237
Open
kwsantiago wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
Open
Pass critical CFLAGS/CXXFLAGS to more build steps#237kwsantiago wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
kwsantiago wants to merge 6 commits intobitcoinknots:29.x-knotsfrom
Conversation
kwsantiago
force-pushed
the
159-build-checks
branch
2 times, most recently
from
3d6400e to
eb8d6f7
Compare
luke-jr
reviewed
Jan 23, 2026
Collaborator
luke-jr
left a comment
luke-jr
left a comment
There was a problem hiding this comment.
What do you think about taking the hardening logic out of /CMakeLists.txt and putting it into a CMake module that we can just use here too? (Maybe make that a separate PR in case it doesn't work out)
kwsantiago
force-pushed
the
159-build-checks
branch
from
94b19a4 to
2480e4f
Compare
Author
kwsantiago
force-pushed
the
159-build-checks
branch
from
2480e4f to
8f6a14b
Compare
Remove -fstack-reuse=none from depends (leaks gcc-only flag into toolchain.cmake, breaking builds that override compiler to clang). The main CMakeLists.txt already handles this via try_append_cxx_flags. Add NO_HARDEN=1 to MSan depends builds since FORTIFY_SOURCE is incompatible with MemorySanitizer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #159