guix: build docker images in the guix process#236
guix: build docker images in the guix process#236Retropex wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
Retropex
force-pushed
the
guix-docker
branch
from
3acf90c to
4db8021
Compare
Retropex
force-pushed
the
guix-docker
branch
from
4db8021 to
96a47c1
Compare
| [INSTALL.md](./INSTALL.md) | ||
|
|
||
| Additionally the `guix-build` script will build a docker compatible image | ||
| which require to install QEMU user static binary. |
There was a problem hiding this comment.
| which require to install QEMU user static binary. | |
| which requires installing the QEMU user static binary. |
| (define-public bitcoin-knots | ||
| (package | ||
| (name "bitcoin-knots") | ||
| (version (getenv "VERSION")) |
There was a problem hiding this comment.
(getenv "VERSION") returns #f if unset, causing (string-append "v" version) on line 28 to fail or produce v#f.
There was a problem hiding this comment.
But VERSION is entirely part of the script and is used even by non docker build, i don't see a case where VERSION is missing.
| (url "https://git.savannah.gnu.org/git/guix.git") | ||
| (branch "master") | ||
| (commit | ||
| "8eed773a70afa696b3b67ca49ee67257b8a44b03") |
There was a problem hiding this comment.
Different Guix commit than prelude.bash (53396a22afc0). Breaks reproducibility.
docker and non-docker builds use different toolchains.
| if [ -n "$dockerpath" ]; then | ||
| cp "$dockerpath" "$OUTDIR_BASE/docker/${DISTNAME}-${host}.tar.gz" | ||
| chmod 644 "$OUTDIR_BASE/docker/${DISTNAME}-${host}.tar.gz" | ||
| sha256sum "$OUTDIR_BASE/docker/${DISTNAME}-${host}.tar.gz" >> "$OUTDIR_BASE/docker/SHA256SUMS.part" |
There was a problem hiding this comment.
SHA256SUMS.part is appended to but never finalized. Re-runs will duplicate entries.
|
Docker hosts fall through to Might want to add |
2 participants
Source for the original guix package