test: Verify debug log message in feature_block.py bad-version test#209
Open
mstampfer wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Open
test: Verify debug log message in feature_block.py bad-version test#209mstampfer wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
mstampfer wants to merge 1 commit intobitcoinknots:29.x-knotsfrom
Conversation
Improve the invalid block version rejection test to verify the debug log contains the expected 'bad-version' rejection message, matching the pattern used in feature_dersig.py and feature_cltv.py. Changes: - Add msg_block import for direct P2P message sending - Replace send_blocks() helper with assert_debug_log() context manager - Send invalid block via send_message() and wait for peer disconnection - Explicitly verify chain tip hasn't advanced after rejection - Add reconnect_p2p() call after peer disconnection This ensures the test verifies both P2P-level rejection and the internal logging behavior from ContextualCheckBlockHeader() in validation.cpp.
Ari4ka
approved these changes
Feb 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve the invalid block version rejection test to verify the debug log contains the expected 'bad-version' rejection message, matching the pattern used in feature_dersig.py and feature_cltv.py.
Changes:
This ensures the test verifies both P2P-level rejection and the internal logging behavior from ContextualCheckBlockHeader() in validation.cpp.