Fix links in CONTRIBUTING.md to point to Knots repository#138
Fix links in CONTRIBUTING.md to point to Knots repository#138aoeui21 wants to merge 1 commit intobitcoinknots:28.x-knotsfrom
Conversation
|
Should we clean up other instances while we're at it? Note that files are only listed once; there may be more instances inside each file which aren't listed in the search results directly. Not all of these should be updated, mind; for example, links to PRs and issues on the With a quick skim of the search results, I think probably:
If we want to direct bug reports here, also:
|
|
Before updating the doc, I think it might be beneficial to clean up the current |
| [good first issue](https://github.com/bitcoin/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) | ||
| [good first issue](https://github.com/bitcoinknots/bitcoin/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22) | ||
| list or changes that are | ||
| [up for grabs](https://github.com/bitcoin/bitcoin/issues?utf8=%E2%9C%93&q=label%3A%22Up+for+grabs%22). |
There was a problem hiding this comment.
Core's lists aren't irrelevant - probably more issues there to address than here.
| 1. Commit patches | ||
|
|
||
| For GUI-related issues or pull requests, the https://github.com/bitcoin-core/gui repository should be used. | ||
| For all other issues and pull requests, the https://github.com/bitcoin/bitcoin node repository should be used. |
There was a problem hiding this comment.
Currently, it's recommended to open PRs to bitcoin/bitcoin when possible, and only on bitcoinknots/bitcoin when the PR is inherently exclusive to Knots.
|
|
||
| Note that translations should not be submitted as pull requests. Please see | ||
| [Translation Process](https://github.com/bitcoin/bitcoin/blob/master/doc/translation_process.md) | ||
| [Translation Process](https://github.com/bitcoinknots/bitcoin/blob/master/doc/translation_process.md) |
There was a problem hiding this comment.
We need to actually have a translation process first.
Core stole the Transifex repo, so the older process no longer works for us
I think almost all remain unresolved?
While there's been some stopgap work to address the most pressing problems, I don't consider it resolved just yet. |
|
Yes, almost all are unresolved. It'll be great if you can spend some time on triaging so people know what the highest priority issues are. |
|
I agree with @luke-jr over here aA direct replacement of bitcoin with bitcoink nots urls is not desirable since it is a little bit more nuanced. Trying and outlining that it is a fork and cover the nuances here for now is best |
5 participants
While reading how to contribute to Bitcoin Knots, I've noticed some links in CONTRIBUTING.md are pointing to the Core's repository.