Introduce an UpdateBuilder#151
Merged
rustaceanrob merged 2 commits intobitcoindevkit:masterfrom Mar 6, 2026
Merged
Conversation
In preparation for bitcoindevkit#150, the `UpdateSubscriber` was handling a large scope. This newtype consolidates the event processing for a wallet, with the intention that `UpdateSubscriber` will simply poll the events and determine when the sync has completed.
Remove the keychain and local chain logic from `UpdateSubscriber` and depend on the `UpdateBuilder`.
rustaceanrob
force-pushed
the
26-3-6-update-builder
branch
from
5c1995c to
10e41c6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mostly a code move, see each commit message for rationale.