feat: Add miniscript key descriptor methods#973
Merged
reez merged 1 commit intobitcoindevkit:masterfrom Mar 31, 2026
Merged
Conversation
d921123 to
a9a2cb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This is the second part of #949. Here I am adding in all the methods that accept
pkas parameter for both single key descriptor and multi.Notes to the reviewers
I have done this in a series of prs to make it easier to review. I looked at this as 2 logical blocks, first is adding methods that take in simple
pkas strings (which is now complete with this pr), second will be adding in methods that take in wrappedpklikeMiniscript<Pk, Segwitv0>,Miniscript<Pk, Legacy>and the likesDocumentation
https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_pkh
https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_wpkh
https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_sh_wpkh
https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_sh_sortedmulti
https://docs.rs/miniscript/12.3.5/miniscript/descriptor/enum.Descriptor.html#method.new_sh_wsh_sortedmulti
bdk_walletbitcoinuniffiOther:
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: