Skip to content

feat: Add miniscript key descriptor methods#973

Merged
reez merged 1 commit intobitcoindevkit:masterfrom
ItoroD:add-keybased-descriptor-methods
Mar 31, 2026
Merged

feat: Add miniscript key descriptor methods#973
reez merged 1 commit intobitcoindevkit:masterfrom
ItoroD:add-keybased-descriptor-methods

Conversation

@ItoroD
Copy link
Copy Markdown
Collaborator

@ItoroD ItoroD commented Mar 19, 2026

Description

This is the second part of #949. Here I am adding in all the methods that accept pk as parameter for both single key descriptor and multi.

Notes to the reviewers

I have done this in a series of prs to make it easier to review. I looked at this as 2 logical blocks, first is adding methods that take in simple pk as strings (which is now complete with this pr), second will be adding in methods that take in wrapped pk like Miniscript<Pk, Segwitv0>, Miniscript<Pk, Legacy> and the likes

Documentation

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing
  • I've added a changelog in the next release tracking issue (see example)
  • I've linked the relevant upstream docs or specs above

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

@ItoroD ItoroD force-pushed the add-keybased-descriptor-methods branch from d921123 to a9a2cb0 Compare March 19, 2026 08:01
Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK a9a2cb0

This mirrors pattern we have nicely

@reez reez merged commit 0778ad4 into bitcoindevkit:master Mar 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants