Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bdk-ffi/Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

37 changes: 37 additions & 0 deletions bdk-ffi/src/bitcoin.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,7 @@ use bdk_wallet::bitcoin::Transaction as BdkTransaction;
use bdk_wallet::bitcoin::TxIn as BdkTxIn;
use bdk_wallet::bitcoin::TxOut as BdkTxOut;
use bdk_wallet::bitcoin::Txid as BitcoinTxid;
use bdk_wallet::bitcoin::Weight;
use bdk_wallet::bitcoin::Wtxid as BitcoinWtxid;
use bdk_wallet::miniscript::psbt::PsbtExt;
use bdk_wallet::serde_json;
Expand Down Expand Up @@ -125,10 +126,12 @@ impl HashableOutPoint {
/// This is an integer type representing fee rate in sat/kwu. It provides protection against mixing
/// up the types as well as basic formatting features.
#[derive(Clone, Debug, uniffi::Object)]
#[uniffi::export(Display)]
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

pub struct FeeRate(pub(crate) BdkFeeRate);

#[uniffi::export]
impl FeeRate {
/// Constructs `FeeRate` from satoshis per virtual bytes.
#[uniffi::constructor]
pub fn from_sat_per_vb(sat_vb: u64) -> Result<Self, FeeRateError> {
let fee_rate: Option<BdkFeeRate> = BdkFeeRate::from_sat_per_vb(sat_vb);
Expand All @@ -138,22 +141,56 @@ impl FeeRate {
}
}

/// Constructs `FeeRate` from satoshis per 1000 weight units.
#[uniffi::constructor]
pub fn from_sat_per_kwu(sat_kwu: u64) -> Self {
FeeRate(BdkFeeRate::from_sat_per_kwu(sat_kwu))
}

/// Converts to sat/vB rounding up.
pub fn to_sat_per_vb_ceil(&self) -> u64 {
self.0.to_sat_per_vb_ceil()
}

/// Converts to sat/vB rounding down.
pub fn to_sat_per_vb_floor(&self) -> u64 {
self.0.to_sat_per_vb_floor()
}

/// Returns raw fee rate.
pub fn to_sat_per_kwu(&self) -> u64 {
self.0.to_sat_per_kwu()
}

/// Calculates fee in satoshis by multiplying this fee rate by weight, in virtual bytes, returning `None` if overflow occurred.
///
/// This is equivalent to converting vb to weight using Weight::from_vb and then calling Self::fee_wu(weight).
pub fn fee_vb(&self, vb: u64) -> Option<Arc<Amount>> {
let rust_amount: BdkAmount = self.0.fee_vb(vb)?;
let amount: Amount = rust_amount.into();
Some(Arc::new(amount))

// The whole code above should be replaceable by the following line:
// self.0.fee_vb(vb).map(Arc::new(Amount::from))
// But in practice you get uniffi compilation errors on it. Not sure what is going on with it,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how weird, good comment for the future when hopefully it resolves itself

// but the code we use works just as well.
}

/// Calculates fee by multiplying this fee rate by weight, in weight units, returning `None` if overflow occurred.
///
/// This is equivalent to Self::checked_mul_by_weight().
pub fn fee_wu(&self, wu: u64) -> Option<Arc<Amount>> {
let weight: Weight = Weight::from_wu(wu);
let rust_amount: BdkAmount = self.0.fee_wu(weight)?;
let amount: Amount = rust_amount.into();
Some(Arc::new(amount))
}
}

impl Display for FeeRate {
fn fmt(&self, f: &mut std::fmt::Formatter) -> std::fmt::Result {
write!(f, "{:#}", self.0)
}
}

impl_from_core_type!(BdkFeeRate, FeeRate);
Expand Down