Update Rust compiler to 1.85.1#851
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Sep 5, 2025
Merged
Conversation
5f80de8 to
adca42a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #828.
A few things are noteworthy for reviewers here. First, I tried the bump just like we always do: updating the CI files and the build scripts. You need to install the new toolchain to then build, and it can be done like this:
But after taking another look at the uniffi repo and the way Mozilla does it, I noticed they were pinning the Rust compiler version in a file called
rust-toolchain.toml, which I had seen before in many Rust projects, including in bdk (which uses the older,rust-versionfile, but it's the same thing they just haven't updated yet). Upon digging into this and trying to see if it could be useful for us, it became clear that it's the wayyyyyyy cleaner way to do things.Calling commands like cargo or rustup in a directory which contains this file will automatically tell cargo/rustup to override whatever version of the Rust compiler they consider default and use the pinned version instead. This means we don't need to specify it explicitly in either the CI runs (and keep it in sync!), or in build scripts. It basically ensures everyone builds using the same version of the Rust compiler, but it's defined in one single place. WIN.
This is what I have implemented here.