Merged
Conversation
53c2777 to
98ef3b3
Compare
98ef3b3 to
8f2d882
Compare
reez
reviewed
Jul 9, 2025
8f2d882 to
f1f25d1
Compare
reez
approved these changes
Jul 9, 2025
f1f25d1 to
56dae5f
Compare
Collaborator
|
just waiting for ci to finish (python tests have been stuck queued for a little while so far) before I merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Exposing
spend_utxowill be helpful when trying to validate signatures or sign transaction inputs. This will allows signers of a psbt to verify and confirm the amount being spent and ensure it is what they expect before they approve/sign the transaction.Notes to the reviewers
spend_utxoreturns a SignError as part of result in case of any errors. We do not have this error type so I skipped this. After testing we still get a fairly descriptive error message when an error occurs. At least for passing an out of bounds index.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: