Skip to content

refactor: use macros for Errors#792

Merged
reez merged 17 commits intobitcoindevkit:masterfrom
reez:mro4
Jul 7, 2025
Merged

refactor: use macros for Errors#792
reez merged 17 commits intobitcoindevkit:masterfrom
reez:mro4

Conversation

@reez
Copy link
Copy Markdown
Collaborator

@reez reez commented Jun 26, 2025

Description

Will add commits for each error I migrate in this PR

Notes to the reviewers

I didn't migrate one error because I wanted/needed one of my other open PR's to get merged before I migrated it.

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez force-pushed the mro4 branch 2 times, most recently from 9a90f24 to bb418ad Compare June 26, 2025 23:10
@reez reez requested a review from ItoroD June 30, 2025 14:28
@reez reez changed the title (draft) refactor: use macros for Errors refactor: use macros for Errors Jun 30, 2025
@reez reez marked this pull request as ready for review June 30, 2025 14:28
Copy link
Copy Markdown
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK bb418ad

Nicely done!

@thunderbiscuit
Copy link
Copy Markdown
Member

Ouuuuu @reez putting in the work to get it across the finish line! Thanks for this, I know it's grunt work and not much fun (hence why I seeked an ENTIRELY DIFFERENT GRANT FOR JUST 2 MONTHS JUST SO I COULD SKIP IT MUAHAHAHAHAHAHA).

@ItoroD
Copy link
Copy Markdown
Collaborator

ItoroD commented Jul 3, 2025

Ouuuuu @reez putting in the work to get it across the finish line! Thanks for this, I know it's grunt work and not much fun (hence why I seeked an ENTIRELY DIFFERENT GRANT FOR JUST 2 MONTHS JUST SO I COULD SKIP IT MUAHAHAHAHAHAHA).

🤣🤣🤣

@reez reez merged commit b822dca into bitcoindevkit:master Jul 7, 2025
24 checks passed
@reez reez deleted the mro4 branch July 7, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants