Skip to content

refactor: use macros for LockTime and PkOrF#790

Merged
reez merged 1 commit intobitcoindevkit:masterfrom
reez:mro2
Jul 7, 2025
Merged

refactor: use macros for LockTime and PkOrF#790
reez merged 1 commit intobitcoindevkit:masterfrom
reez:mro2

Conversation

@reez
Copy link
Copy Markdown
Collaborator

@reez reez commented Jun 26, 2025

Description

Migrate LockTime and PkOrF to use proc macro

Notes to the reviewers

Changelog notice

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

@reez reez changed the title refactor: use macros for LockTime and PkOrF (draft) refactor: use macros for LockTime and PkOrF Jun 26, 2025
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 545ed37.

@reez reez marked this pull request as ready for review June 30, 2025 14:26
@reez reez changed the title (draft) refactor: use macros for LockTime and PkOrF refactor: use macros for LockTime and PkOrF Jun 30, 2025
@reez reez merged commit 759c5f9 into bitcoindevkit:master Jul 7, 2025
24 checks passed
@reez reez deleted the mro2 branch July 7, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants