TxGraphChangeSet: Include first_seen and last_evicted#782
Merged
reez merged 2 commits intobitcoindevkit:masterfrom Jun 12, 2025
Merged
TxGraphChangeSet: Include first_seen and last_evicted#782reez merged 2 commits intobitcoindevkit:masterfrom
reez merged 2 commits intobitcoindevkit:masterfrom
Conversation
ItoroD
force-pushed
the
update-txgraphchangeset-fields
branch
2 times, most recently
from
e7aafa2 to
bdd12be
Compare
ItoroD
commented
Jun 10, 2025
ItoroD
changed the title
reez
approved these changes
Jun 12, 2025
Collaborator
There was a problem hiding this comment.
ACK bdd12be
Great work implementing the new fields, changing that naming in the python test is optional #782 (comment), but I'll let you change that if you want because it's a good idea.
ItoroD
force-pushed
the
update-txgraphchangeset-fields
branch
from
bdd12be to
b0c75ca
Compare
Collaborator
Author
Thanks for the review! I have rebased. I also updated the variable name to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
tx_graph::ChangeSetnow has additional fields as at 2.0.0-beta.first_seenandlast_evicted. This pr adds them to TxGraphChangeSet type.Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committing