Skip to content

Add new Kyoto conf#775

Merged
reez merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:kyoto-5-30
Jun 4, 2025
Merged

Add new Kyoto conf#775
reez merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:kyoto-5-30

Conversation

@rustaceanrob
Copy link
Copy Markdown
Collaborator

@rustaceanrob rustaceanrob commented May 30, 2025

Changelog notice

  • Add connection timeout parameters to Kyoto

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

@rustaceanrob rustaceanrob changed the title Add new Kyoto conf and method to run nodes Add new Kyoto conf May 30, 2025
@rustaceanrob rustaceanrob marked this pull request as ready for review May 30, 2025 13:43
Copy link
Copy Markdown
Collaborator

@ItoroD ItoroD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Will try a simulation with this on our dev-kit wallet

Users may want to fiddle with these parameters for a production wallet.
The defaults are quiet conservative and could be more aggressive on fast
internet
@rustaceanrob
Copy link
Copy Markdown
Collaborator Author

Updated to use Duration as the const values because from_secs is const

Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 27a3941.

@reez reez merged commit e59b1e7 into bitcoindevkit:master Jun 4, 2025
26 checks passed
@rustaceanrob rustaceanrob deleted the kyoto-5-30 branch June 4, 2025 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants