Add lookahead as optional argument#770
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom May 28, 2025
Merged
Conversation
Member
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Thanks for adding this! Just one question/comment.
| /// | ||
| /// If you have previously created a wallet, use load instead. | ||
| #[uniffi::constructor] | ||
| #[uniffi::constructor(default(lookahead = None))] |
Member
There was a problem hiding this comment.
I wonder if using the default lookahead in bdk_wallet might make more sense for users looking at the default values. As is, you might think that unless one is set, your lookahead will be null (even though that doesn't really make sense) but that's not true (the default is 25).
Collaborator
Author
There was a problem hiding this comment.
Gotcha. Is there a way to use constants or do we hard-code 25?
Collaborator
Author
There was a problem hiding this comment.
Answered that for myself. Macro requires a literal, so must be hard coded at 25.
Using the default argument here, so this should actually be non-breaking. Compared to a builder this is ergonomic in the target languages IMO
rustaceanrob
force-pushed
the
lookahead-5-28
branch
from
55d9f09 to
04756c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Users may want to configure the initial
lookaheadvalue of a wallet, but we can leave this optional.Using the default argument here, so this should actually be non-breaking. Compared to a builder this is ergonomic in the target languages IMO
Changelog notice
lookaheadas optional wallet configurationChecklists
All Submissions:
cargo fmtandcargo clippybefore committing