Skip to content

Export public types from Script#763

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:export-pub-5-13
May 13, 2025
Merged

Export public types from Script#763
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:export-pub-5-13

Conversation

@rustaceanrob
Copy link
Copy Markdown
Collaborator

Description

I was developing on the latest commit in master and the script API was missing because it was not annotated with uniffi::export. I did a quick audit of the impl blocks but probably worth another pass by someone else to see if there are impl blocks missing exports

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ed7064f.

@thunderbiscuit thunderbiscuit merged commit ed7064f into bitcoindevkit:master May 13, 2025
26 checks passed
@rustaceanrob rustaceanrob deleted the export-pub-5-13 branch May 13, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants