Expose latest_checkpoint in Wallet implementation

[ItoroD]

Changelog notice

Checklists

All Submissions:

• I've signed all my commits
• I followed the contribution guidelines
• I ran cargo fmt and cargo clippy before committing

New Features:

• I've added tests for the new feature

[ItoroD]

Not sure if the println added to test LiveTransactionTest.kt is necessary. I figured it might be worth putting it there to test that the lastest_checkpoint addition works. Creating a whole new test for just that seemed overkill. Let me know it I should take it out.

[thunderbiscuit]

Looks good! One little comment and I think it's good to go.

[thunderbiscuit]

Here I think you can use the new BlockHash type if you strong-type the hash field in the BlockId type.

[ItoroD]

When I attempt to update hash type to BlockHash, I get an error at compile.

the trait uniffi::Lower<UniFfiTag> is not implemented for bitcoin::BlockHash

Assuming BlockHash works, I will need to deal with the other places using hash of BlockId type I have identified just 1 place so far. (FYI)

[ItoroD]

Ok it works. Issue was that I did not add the Arc around the BlockHash. My bad!

[ItoroD]

I noticed a test is expecting String for BlockHash (hence the failing test even). Its the binding test. I will update it.

[thunderbiscuit]

Just one last little thing!

As for the tests, you can actually remove the blockId variables from the tests. They were intended to test the bindings generation for bitcoin-ffi and bdk-ffi (as per the comments), but now we only use bdk-ffi so you can just keep the network enum and the tests will do what we need them to do. Just to be clear this is what I mean:

// Swift
let network = Network.testnet

// Kotlin
val network = Network.TESTNET

# Python
class TestBdk(unittest.TestCase):

    def test_some_enum(self):
        network = Network.TESTNET

if __name__=='__main__':
    unittest.main()

[thunderbiscuit]

I think here you should use Arc::new() instead of Arc::from().

[ItoroD]

Yes. I noticed. Thanks!

[thunderbiscuit]

ACK 34aa59f.