Skip to content

Update bdk_kyoto to 0.9.0#755

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:kyoto-5-5
May 13, 2025
Merged

Update bdk_kyoto to 0.9.0#755
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:kyoto-5-5

Conversation

@rustaceanrob
Copy link
Copy Markdown
Collaborator

Debug strings and info messages from Kyoto are on separate channels now. TxSent is renamed to TxGossiped and is only emitted if we are sure that the remote node has requested the transaction from us and we could successfully send it. The node accepts a Socks5 proxy to route traffic over Tor. I added a specific Socks5Proxy for this. We also return a Update directly instead of an optional. This makes it clear Kyoto has synced, even if there may be duplicate information. A handful of methods on the client were also converted to synchronous calls.

Internally the bdk_kyoto crate simply provides an extension trait over the Kyoto node builder, so users can take full advantage of the Kyoto features build still build for a specific Wallet. I will follow up with some additional configurations on the builder that are non-breaking.

Changelog notice

  • Add Socks5 proxy to Kyoto client options
  • Separate debug strings and Info messages for CbfClient
  • CbfClient returns an Update instead of optional

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Copy Markdown
Collaborator

@reez reez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 78a1134

@thunderbiscuit
Copy link
Copy Markdown
Member

This one needs a quick rebase and is ready to go.

Debug strings and info messages from Kyoto are on separate channels now.
`TxSent` is renamed to `TxGossiped` and is only emitted if we are sure
that the remote node has requested the transaction from us and we could
successfully send it. The node accepts a Socks5 proxy to route traffic
over Tor. I added a specific `Socks5Proxy` for this.

Internally the `bdk_kyoto` crate simply provides an extension trait over
the Kyoto node builder, so users can take full advantage of the Kyoto
features build still build for a specific `Wallet`. I will follow up
with some additional configurations on the builder that are
non-breaking.
@rustaceanrob
Copy link
Copy Markdown
Collaborator Author

Rebased

@thunderbiscuit thunderbiscuit merged commit 881097d into bitcoindevkit:master May 13, 2025
26 checks passed
@rustaceanrob rustaceanrob deleted the kyoto-5-5 branch May 13, 2025 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants