Use macros for SignOptions#749
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Apr 30, 2025
Merged
Conversation
rustaceanrob
force-pushed
the
sign-opt-4-28
branch
from
db7ebb6 to
d57bf15
Compare
thunderbiscuit
approved these changes
Apr 30, 2025
Member
thunderbiscuit
left a comment
thunderbiscuit
left a comment
There was a problem hiding this comment.
Needs a rebase, but otherwise is ready to go.
ACK d57bf15.
rustaceanrob
force-pushed
the
sign-opt-4-28
branch
from
d57bf15 to
5081587
Compare
Collaborator
Author
|
Re |
rustaceanrob
force-pushed
the
sign-opt-4-28
branch
from
5081587 to
1db5a7b
Compare
Collaborator
Author
|
Rebased 1db5a7b |
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cargo fmtandcargo clippybefore committing