Migrate EsploraClient to procedural macros#740
Merged
thunderbiscuit merged 3 commits intobitcoindevkit:masterfrom Apr 24, 2025
Merged
Migrate EsploraClient to procedural macros#740thunderbiscuit merged 3 commits intobitcoindevkit:masterfrom
EsploraClient to procedural macros#740thunderbiscuit merged 3 commits intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
force-pushed
the
refactor/bye-bye-udl
branch
from
7636eb1 to
b041ebe
Compare
thunderbiscuit
force-pushed
the
refactor/bye-bye-udl
branch
from
b041ebe to
c96d010
Compare
Collaborator
Its amazing! Even more so that you do not have to worry about maintaining sync in 2 files. Everything on one side now |
reez
approved these changes
Apr 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR focuses on the Esplora Client.
Nothing crazy to note. Still crazy to me that you can remove 58 lines of UDL at the cost of 3 lines in the Rust source.