Migrate ChangeSpendPolicy type to procedural macros#737
Merged
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom Apr 24, 2025
Merged
Migrate ChangeSpendPolicy type to procedural macros#737thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom
ChangeSpendPolicy type to procedural macros#737thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom
Conversation
reez
reviewed
Apr 23, 2025
| use std::str::FromStr; | ||
| use std::sync::Arc; | ||
|
|
||
| type ChangeSpendPolicy = bdk_wallet::ChangeSpendPolicy; |
Collaborator
There was a problem hiding this comment.
more out of curiosity (and not having as many reps as you on this) than me thinking its wrong or anything, what made you have to do this (function, aesthetic, etc)?
Member
Author
There was a problem hiding this comment.
Yeah it's weird. This is how you have to do it for remote types. I'm still not sure how that works internally. Their docs are sparse. https://mozilla.github.io/uniffi-rs/latest/types/remote_ext_types.html#remote-types
Collaborator
There was a problem hiding this comment.
there's a lot of new stuff that's pretty interesting with this. Thanks for the link!
thunderbiscuit
force-pushed
the
feature/proc-macros
branch
from
8429a0e to
1a8e4bc
Compare
thunderbiscuit
force-pushed
the
feature/proc-macros
branch
from
1a8e4bc to
602ab7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is done as a remote type.
Let me know if you have any questions!
The second commit is addressing clippy warnings of unused imports.