refactor: migrate errors thrown by wallet to procedural macros#733
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Apr 22, 2025
Merged
Conversation
thunderbiscuit
force-pushed
the
feature/proc-macros
branch
from
13bb471 to
954232d
Compare
thunderbiscuit
force-pushed
the
feature/proc-macros
branch
from
954232d to
652edcf
Compare
reez
approved these changes
Apr 22, 2025
Collaborator
Then I guess |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is bigger but simpler. Errors migrated here were all only used by the
Wallettype, and can therefore be removed completely from the UDL file.The 3 PRs from this morning amount to a fair amount of changes. I'm running all live tests on this branch just for an extra check.