refactor: migrate Wallet type to procedural macros#732
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Apr 22, 2025
Merged
refactor: migrate Wallet type to procedural macros#732thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
Collaborator
I assume this is the rule for any optional? |
Collaborator
Thanks for noting this |
reez
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate the Wallet and related errors.
Note that default arguments (here
sign_options) require special annotations:As more and more types in the UDL are declared with
The types that were only used in the UDL as part of that type (arguments on methods or return values of
ExampleType) can be removed entirely from the UDL. So far these come up as unused types warnings when running clippy so they're easy to identify, but I wonder if I missed some.