Migrate Connection type to procedural macros#731
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Apr 22, 2025
Merged
Migrate Connection type to procedural macros#731thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Connection type to procedural macros#731thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
Connection type to procedural macros
Collaborator
THANKS for calling this out, I was confused but then I looked at this and it cleared it up for me! |
reez
approved these changes
Apr 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migration of the
Connectiontype.Docs pulled directly from the rusqlite crate: https://docs.rs/rusqlite/0.31.0/rusqlite/struct.Connection.html#method.open
One thing to note is that with proc macros, all methods in an
implblock will be exported if that block is marked with the#uniffi::exportannotation, meaning that if we want to keep some methods private/out of the public API for the bindings (for example theConnection::get_store()), they simply need to be brought into a separate impl block.