Skip to content

Use uniffi::Remote where applicable in module Kyoto#719

Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:remote-kyoto-4-2
Apr 2, 2025
Merged

Use uniffi::Remote where applicable in module Kyoto#719
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
rustaceanrob:remote-kyoto-4-2

Conversation

@rustaceanrob
Copy link
Copy Markdown
Collaborator

Description

Removing all Kyoto types from the UDL, and using the uniffi::remote macro wherever applicable in the module.

Notes to the reviewers

I was not aware of uniffi::Remote until a recent PR, so this cleans up the Kyoto module significantly. Cheers.

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added tests for the new feature
  • I've added docs for the new feature

Bugfixes:

  • This pull request breaks the existing API
  • I've added tests to reproduce the issue which are now passing
  • I'm linking the issue being fixed by this PR

Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

Tested ACK e29a4c1.

@thunderbiscuit thunderbiscuit merged commit e29a4c1 into bitcoindevkit:master Apr 2, 2025
26 checks passed
@rustaceanrob rustaceanrob deleted the remote-kyoto-4-2 branch April 2, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants