Use uniffi::Remote where applicable in module Kyoto#719
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Apr 2, 2025
Merged
Use uniffi::Remote where applicable in module Kyoto#719thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
uniffi::Remote where applicable in module Kyoto#719thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
approved these changes
Apr 2, 2025
Member
thunderbiscuit
left a comment
There was a problem hiding this comment.
Awesome stuff!
Tested ACK e29a4c1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removing all Kyoto types from the UDL, and using the
uniffi::remotemacro wherever applicable in the module.Notes to the reviewers
I was not aware of
uniffi::Remoteuntil a recent PR, so this cleans up the Kyoto module significantly. Cheers.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: