Skip to content

Migrate Transaction to pro-macros#718

Merged
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom
ItoroD:macros-transaction
Apr 23, 2025
Merged

Migrate Transaction to pro-macros#718
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom
ItoroD:macros-transaction

Conversation

@ItoroD
Copy link
Copy Markdown
Collaborator

@ItoroD ItoroD commented Mar 31, 2025

Description

This PR migrates Transaction to pro-macros

Notes to the reviewers

Checklists

All Submissions:

  • I've signed all my commits
  • I followed the contribution guidelines
  • I ran cargo fmt and cargo clippy before committing

New Features:

  • I've added docs for the new feature

@ItoroD ItoroD changed the title Macros transaction Migrate Transaction to pro-macros Mar 31, 2025
Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome stuff!

To answer your questions:

  1. Not sure what the Policy link is. Can you elaborate? But right now your vsize doc looks good to me!
  2. For serialize, I would instead use
/// Serialize transaction into consensus-valid format. See https://docs.rs/bitcoin/latest/bitcoin/struct.Transaction.html#serialization-notes for more notes on transaction serialization.
  1. I think it makes sense to have docs for the main constructor.

@ItoroD
Copy link
Copy Markdown
Collaborator Author

ItoroD commented Apr 23, 2025

Awesome stuff!

To answer your questions:

  1. Not sure what the Policy link is. Can you elaborate? But right now your vsize doc looks good to me!

Thanks for the feedback!

There is a hyperlink that says policy in the doc for vsize here. That link is broken. So I took it out in this PR.

image

@ItoroD ItoroD force-pushed the macros-transaction branch from 6d21a9d to 8fdce47 Compare April 23, 2025 13:52
@ItoroD ItoroD force-pushed the macros-transaction branch from 8fdce47 to d069771 Compare April 23, 2025 13:55
@thunderbiscuit
Copy link
Copy Markdown
Member

Oh I see! Perfect yep.

Copy link
Copy Markdown
Member

@thunderbiscuit thunderbiscuit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK d069771.

@thunderbiscuit thunderbiscuit merged commit d069771 into bitcoindevkit:master Apr 23, 2025
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants