Migrate Transaction to pro-macros#718
Merged
thunderbiscuit merged 2 commits intobitcoindevkit:masterfrom Apr 23, 2025
Merged
Conversation
Member
thunderbiscuit
left a comment
There was a problem hiding this comment.
Awesome stuff!
To answer your questions:
- Not sure what the Policy link is. Can you elaborate? But right now your vsize doc looks good to me!
- For serialize, I would instead use
/// Serialize transaction into consensus-valid format. See https://docs.rs/bitcoin/latest/bitcoin/struct.Transaction.html#serialization-notes for more notes on transaction serialization.
- I think it makes sense to have docs for the main constructor.
Collaborator
Author
Thanks for the feedback! There is a hyperlink that says |
6d21a9d to
8fdce47
Compare
8fdce47 to
d069771
Compare
Member
|
Oh I see! Perfect yep. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR migrates
Transactionto pro-macrosNotes to the reviewers
fn vsize(&self)see main doc [here ]. So I took that part out of the doc here (https://docs.rs/bitcoin/latest/bitcoin/struct.Transaction.html#method.vsize)Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: