Configure log level and DNS resolver#701
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Mar 27, 2025
Merged
Conversation
3c3ff8f to
2376478
Compare
2376478 to
0287453
Compare
Collaborator
Author
|
Rebased |
Member
|
Looks good to me, I'd merge this one next. One thing I just tried locally (it's my first time using a straight remote type that doesn't need wrapping with the proc macros) is the procedure defined on this page: https://mozilla.github.io/uniffi-rs/latest/types/remote_ext_types.html. All live Kyoto tests pass on my end. // Remove this line
// use bdk_kyoto::kyoto::LogLevel as BDKLogLevel;
// Replace with
type LogLevel = bdk_kyoto::kyoto::LogLevel;
/// Select the category of messages for the node to emit.
#[uniffi::remote(Enum)]
pub enum LogLevel {
/// Send `Log::Debug` messages. These messages are intended for debugging or troubleshooting
/// node operation.
Debug,
/// Omit `Log::Debug` messages, including their memory allocations. Ideal for a production
/// application that uses minimal logging.
Warning,
}
// The From<LogLevel> for BDKLogLevel trait implementation can be deletedHow do you feel about this approach? It basically removes the requirement to write a wrapper on the type. There are other places where we should use this, for example on the |
0287453 to
58e31c7
Compare
Collaborator
Author
|
I took a shallow attempt at this and overlooked |
58e31c7 to
bb89233
Compare
Member
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Partial steps towards #700 that are uncontroversial feature additions. The
LogLevelenum allows for filtering theLog::Debugmessages, which are mostly used for debugging and require a string allocation. Without these messages the node should sync even faster in a production application that communicates with a UI. Other developers may have a preferred DNS resolver they would like to point their users at. That is easily configurable as well.Notes to the reviewers
It appears the lockfile was not updated when the
Cargo.tomlchanged versions.Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
Bugfixes: