Migrate TxBuilder type to procedural macros#691
Merged
thunderbiscuit merged 4 commits intobitcoindevkit:masterfrom Mar 25, 2025
Merged
Migrate TxBuilder type to procedural macros#691thunderbiscuit merged 4 commits intobitcoindevkit:masterfrom
thunderbiscuit merged 4 commits intobitcoindevkit:masterfrom
Conversation
thunderbiscuit
changed the title
thunderbiscuit
force-pushed
the
refactor/macros-1
branch
2 times, most recently
from
efb0a5b to
2730abb
Compare
Member
Author
|
I ran all JVM live tests locally and everything passes. |
thunderbiscuit
force-pushed
the
refactor/macros-1
branch
from
fe8039a to
7ef6054
Compare
|
|
||
| #[uniffi::export] | ||
| impl TxBuilder { | ||
| #[uniffi::constructor] |
Collaborator
There was a problem hiding this comment.
I realized in Kotlin is that our struct-level docs might actually want to live at the constructor, at least that's how it felt in the natural flow of things. Something to experiment with for later
Collaborator
|
ACK 7ef6054 |
reez
approved these changes
Mar 24, 2025
thunderbiscuit
force-pushed
the
refactor/macros-1
branch
from
7ef6054 to
b1d6aca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying out the proc macros on the TxBuilder.
A few things I want to keep in mind and look out for: