Expose ElectrumClient::ping method#689
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Mar 10, 2025
Merged
Conversation
thunderbiscuit
force-pushed
the
feature/ping
branch
from
916fb27 to
9b0e732
Compare
reez
approved these changes
Mar 10, 2025
Collaborator
reez
left a comment
reez
left a comment
There was a problem hiding this comment.
ACK 9b0e732
Looks pretty straightforward https://docs.rs/electrum-client/0.22.0/electrum_client/trait.ElectrumApi.html#tymethod.ping to me so this PR makes sense how it exposes that method
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Somehow I had forgotten this one as part of #662.
The ping either returns the unit type or an error.
Changelog notice
Added: - New `ElectrumClient::ping` method [#689] [#689]: https://github.com/bitcoindevkit/bdk-ffi/pull/689Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features: