Add Descriptor::desc_type method#688
Merged
thunderbiscuit merged 1 commit intobitcoindevkit:masterfrom Aug 1, 2025
Merged
Conversation
thunderbiscuit
force-pushed
the
feature/descriptors
branch
from
ccb9f62 to
4bab1c2
Compare
Member
Author
|
I removed all tests for descriptors that cannot be parsed by miniscript (as far as I can tell, will need to research a bit more). These are examples from the BIPs that the library can't parse: Descriptor("sortedmulti(1,04a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd5b8dec5235a0fa8722476c7709c02559e3aa73aa03918ba2d492eea75abea235,03a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd)", Network.BITCOIN)
Descriptor("combo(04a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd5b8dec5235a0fa8722476c7709c02559e3aa73aa03918ba2d492eea75abea235)", Network.BITCOIN)
Descriptor("raw(512103a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd4104a34b99f22c790c4e36b2b3c2c35a36db06226e41c692fc82b8b56ac1c540c5bd5b8dec5235a0fa8722476c7709c02559e3aa73aa03918ba2d492eea75abea23552ae)", Network.BITCOIN)
Descriptor("addr(3PUNyaW7M55oKWJ3kDukwk9bsKvryra15j)", Network.BITCOIN) |
thunderbiscuit
force-pushed
the
feature/descriptors
branch
from
4bab1c2 to
7804543
Compare
Member
Author
|
This is finally ready for review/merge. There is much more to do with the |
reez
approved these changes
Aug 1, 2025
thunderbiscuit
force-pushed
the
feature/descriptors
branch
from
7804543 to
b79b1a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proof of Concept. Will keep iterating. The parsing of some miniscripts that are according to the BIP valid also fails, and I don't know exactly why but assume it's because those are not supported by the miniscript crate? Not sure yet (you can see some of the tests I commented out).
Descriptors taken from the BIPs here: https://github.com/bitcoin/bips/blob/master/bip-0380.mediawiki
See #687.