Closed
Conversation
Collaborator
Author
|
On the last screen of send flow it would be nice to show fee rate (already show fee in sats), especially for this sort of thing |
Collaborator
Author
|
bitcoindevkit/bdk-ffi#859 might make this pr even nicer/cleaner |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Test support for sub 1 sat fees.
Notes to the reviewers
FeeRatesupports https://docs.rs/bitcoin-units/0.1.2/bitcoin_units/fee_rate/struct.FeeRate.htmlNeeded to update a method in BDKService.
(hardcoded fee for testing)
If I did 0.5, I got
sendrawtransaction RPC error: {"code":-26,"message":"min relay fee not met, 72 < 142"}So then I went to 0.99 (worked but is within current policy so not surprising) https://mempool.space/testnet4//tx/fa7e423f5cdebf1b1d5c1efa67aaed4350ec0fb6347200398f4f678b9256957f
Changelog notice
Checklists
All Submissions:
.swift-formatfileNew Features:
Bugfixes: