Conversation
|
8f61274 tested by using ffi |
|
tested local build of bitcoindevkit/bdk-ffi#777 (no changes to iOS app that I'm seeing) |
reez
force-pushed
the
ffi-756
branch
3 times, most recently
from
20da6be to
4049420
Compare
| blockId: .init( | ||
| height: UInt32(12), | ||
| hash: "hash" | ||
| hash: try! BlockHash.fromBytes( |
There was a problem hiding this comment.
BlockHash changed from String to type bitcoindevkit/bdk-ffi@23d14f0
Would be nice to have a String constructor again somehow
| confirmationTime: UInt64(21) | ||
| ), | ||
| transitively: "c1f9fe0d7f97c6490f8360cf71bbef151f2e73302bd06f1690d640b96fb94457" | ||
| transitively: try! Txid.fromBytes( |
There was a problem hiding this comment.
Txid changed from String to type bitcoindevkit/bdk-ffi@23d14f0
Would be nice to have a String constructor again somehow
| static var mock = LocalOutput( | ||
| outpoint: OutPoint( | ||
| txid: "txid", | ||
| txid: try! Txid.fromBytes( |
There was a problem hiding this comment.
Txid changed from String to type bitcoindevkit/bdk-ffi@23d14f0
Would be nice to have a String constructor again somehow
| txout: TxOut( | ||
| value: UInt64(1), | ||
| scriptPubkey: Script(rawOutputScript: [UInt8(1)]) | ||
| scriptPubkey: Script.init(rawOutputScript: Data([0x51])) |
There was a problem hiding this comment.
Script now expects Data
here's 1.2 with UDL https://github.com/bitcoindevkit/bdk-ffi/blob/release/1.2/bdk-ffi/src/bdk.udl#L1237C1-L1242C1
here's 2.0 with script bitcoindevkit/bdk-ffi@ed7064f
| import Foundation | ||
| import BitcoinDevKit | ||
|
|
||
| extension OutPoint: Hashable { |
There was a problem hiding this comment.
Outpoint went to Record from object so lost its Hashable/Equatable in the process, so added this because of that
| extension Transaction { | ||
| var transactionID: String { | ||
| return self.computeTxid() | ||
| return "\(self.computeTxid())" |
There was a problem hiding this comment.
function returned String but now returns Txid
| extension Transaction { | ||
| static var mock = try? Transaction( | ||
| transactionBytes: String.mockTransactionHex.hexStringToByteArray() | ||
| transactionBytes: Data(String.mockTransactionHex.hexStringToByteArray()) |
There was a problem hiding this comment.
I think similar-ish to https://github.com/bitcoindevkit/BDKSwiftExampleWallet/pull/297/files#r2124988471 ?
new expectation is Data as argument type
| VStack(alignment: .leading, spacing: 5) { | ||
|
|
||
| Text(output.outpoint.txid) | ||
| Text(output.outpoint.txid.description) |
There was a problem hiding this comment.
Outpoint uses txid which is a type not a string now
|
closing in favor of #302 |
1 participant
Description
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-formatfileNew Features:
Bugfixes: