Skip to content

Conversation

@oskarszoon
Copy link
Collaborator

Description of Changes

Chronicle release removes push-only restriction for version 2+ transactions.
Fixes "arc error 463: transaction input unlocking script is not push only" for v2 txs

Testing Procedure

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist:

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have updated CHANGELOG.md with my changes

@sonarqubecloud
Copy link

@oskarszoon oskarszoon changed the title Allow non-push-only unlocking scripts for v2+ transactions fix: allow non-push-only unlocking scripts for v2+ transactions Jan 19, 2026
@oskarszoon oskarszoon merged commit 5e7790e into main Jan 19, 2026
7 of 8 checks passed
@oskarszoon oskarszoon deleted the feature/chronicle branch January 19, 2026 14:29
if input.UnlockingScript == nil {
return errors.Join(ErrEmptyUnlockingScript, fmt.Errorf("input: %d", index))
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@oskarszoon
Shouldn't theif tx.Version >= 2 be done just before the if !parsedUnlockingScript.IsPushOnly() {
once we make sure that there are not errors in the parsing of the unlocking script? So like this instead:


		parser := interpreter.DefaultOpcodeParser{}
		parsedUnlockingScript, err := parser.Parse(input.UnlockingScript)
		if err != nil {
			return err
		}

		// Chronicle release: version 2+ transactions allow non-push-only unlocking scripts
		if tx.Version >= 2 {
			continue
		}

		if !parsedUnlockingScript.IsPushOnly() {
			return errors.Join(ErrUnlockingScriptNotPushOnly, fmt.Errorf("input: %d", index))
		}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants