support BitBox02 Nova by updating bitbox02 lib to v7.0.0#789
support BitBox02 Nova by updating bitbox02 lib to v7.0.0#789benma wants to merge 2 commits intobitcoin-core:masterfrom
Conversation
This adds support for BitBox02 Nova. It has the same API has BitBox02.
| # Python BitBox02 Library | ||
|
|
||
| This is a slightly modified version of the official [bitbox02](https://github.com/digitalbitbox/bitbox02-firmware/tree/master/py/bitbox02) library. | ||
| This is a slightly modified version of the official [bitbox02](https://github.com/BitBoxSwiss/bitbox02-firmware/tree/master/py/bitbox02) library. |
There was a problem hiding this comment.
Looks like the Github repo moved without a redirect. I checked on https://bitbox.swiss/dev/ that the new org account is correct.
There was a problem hiding this comment.
What do you mean by 'without a redirect'?
https://github.com/digitalbitbox/bitbox02-firmware/tree/master/py/bitbox02 redirects to https://github.com/BitBoxSwiss/bitbox02-firmware/tree/master/py/bitbox02
|
I'm trying this out against the repaired CI in #801. I noticed this PR does not touch CI at all. Is it simply replacing Bitbox 02 simulator with the new Nova device? It seems better to run both. This could be done by adding the new device to the I see the firmware binaries are identical: https://github.com/BitBoxSwiss/bitbox02-firmware/blob/master/releases/README.md As is the simulator? |
|
Thanks for taking a look!
Exactly, the same firmware runs on both devices, and the API is the same, so there is no need to change anything in the CI. |
|
@Sjors can we merge? Would be great to have a release including this PR out soon too. |
|
Something has changed? When I include this in #795 now, CI still breaks: https://github.com/bitcoin-core/HWI/actions/runs/17324099849/job/49184179642?pr=795#step:3:1866 |
Indeed, the path to the simulator bin has changed in the BB02 repo. I added a commit to fix it. Imho it would make sense not to build |
|
Thanks, I cherry-picked it into #795.
I tend to agree, but for now I'll just play the whackamole game.
That's one option, but just using release tags or fixed commits would already be an improvement for stability. |
|
Let's continue debugging it over in #795. |
|
This has been merged via #795 so can be closed. |
Thank you very much for pushing this! |
This adds support for BitBox02 Nova. It has the same API has BitBox02.