Skip to content

support BitBox02 Nova by updating bitbox02 lib to v7.0.0#789

Closed
benma wants to merge 2 commits intobitcoin-core:masterfrom
benma:bump-bitbox
Closed

support BitBox02 Nova by updating bitbox02 lib to v7.0.0#789
benma wants to merge 2 commits intobitcoin-core:masterfrom
benma:bump-bitbox

Conversation

@benma
Copy link
Copy Markdown
Contributor

@benma benma commented Jul 17, 2025

This adds support for BitBox02 Nova. It has the same API has BitBox02.

This adds support for BitBox02 Nova. It has the same API has BitBox02.
# Python BitBox02 Library

This is a slightly modified version of the official [bitbox02](https://github.com/digitalbitbox/bitbox02-firmware/tree/master/py/bitbox02) library.
This is a slightly modified version of the official [bitbox02](https://github.com/BitBoxSwiss/bitbox02-firmware/tree/master/py/bitbox02) library.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the Github repo moved without a redirect. I checked on https://bitbox.swiss/dev/ that the new org account is correct.

Copy link
Copy Markdown
Contributor Author

@benma benma Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Jul 24, 2025

I'm trying this out against the repaired CI in #801. I noticed this PR does not touch CI at all. Is it simply replacing Bitbox 02 simulator with the new Nova device?

It seems better to run both. This could be done by adding the new device to the sim-builder-bitbox matrix (assuming #795 is merged), and then add it to the matrix in test-bitbox-dist and test-bitbox.


I see the firmware binaries are identical: https://github.com/BitBoxSwiss/bitbox02-firmware/blob/master/releases/README.md

As is the simulator?

@benma
Copy link
Copy Markdown
Contributor Author

benma commented Jul 25, 2025

Thanks for taking a look!

I see the firmware binaries are identical: https://github.com/BitBoxSwiss/bitbox02-firmware/blob/master/releases/README.md

As is the simulator?

Exactly, the same firmware runs on both devices, and the API is the same, so there is no need to change anything in the CI.

@benma
Copy link
Copy Markdown
Contributor Author

benma commented Aug 3, 2025

@Sjors can we merge? Would be great to have a release including this PR out soon too.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Aug 3, 2025

That's up to @achow101, ideally we'd merge #795 first so you can rebase and then merge this with green CI.

@Sjors Sjors mentioned this pull request Aug 29, 2025
@Sjors
Copy link
Copy Markdown
Member

Sjors commented Aug 29, 2025

Something has changed? When I include this in #795 now, CI still breaks:

tar: test/work/bitbox02-firmware/build-build/bin/simulator: Cannot stat: No such file or directory

https://github.com/bitcoin-core/HWI/actions/runs/17324099849/job/49184179642?pr=795#step:3:1866

@benma
Copy link
Copy Markdown
Contributor Author

benma commented Aug 29, 2025

Something has changed? When I include this in #795 now, CI still breaks:

tar: test/work/bitbox02-firmware/build-build/bin/simulator: Cannot stat: No such file or directory

https://github.com/bitcoin-core/HWI/actions/runs/17324099849/job/49184179642?pr=795#step:3:1866

Indeed, the path to the simulator bin has changed in the BB02 repo. I added a commit to fix it.

Imho it would make sense not to build master of all the HWW repos, it's very fragile and causes the HWI CI to randomly break. It's not HWI's responsibility to make sure unreleased HWW firmwares are working. Have you considered just pulling the latest simulator (and bitcoind) binaries in the CI instead? It would speed up CI a lot and not cause random breaks, and updates to them can be done in dedicated PRs that also fix potential new issues.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Aug 29, 2025

Thanks, I cherry-picked it into #795.

Imho it would make sense not to build master of all the HWW repos, it's very fragile and causes the HWI CI to randomly break.

I tend to agree, but for now I'll just play the whackamole game.

Have you considered just pulling the latest simulator (and bitcoind) binaries in the CI instead?

That's one option, but just using release tags or fixed commits would already be an improvement for stability.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Aug 29, 2025

Let's continue debugging it over in #795.

@Sjors
Copy link
Copy Markdown
Member

Sjors commented Sep 4, 2025

This has been merged via #795 so can be closed.

@benma
Copy link
Copy Markdown
Contributor Author

benma commented Sep 4, 2025

This has been merged via #795 so can be closed.

Thank you very much for pushing this!

@benma benma closed this Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants